Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13798#discussion_r67810125
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -689,67 +689,67 @@ setGeneric("randomSplit", function(x, weights, seed) 
{ standardGeneric("randomSp
     
     ###################### Column Methods ##########################
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("asc", function(x) { standardGeneric("asc") })
     
    -#' @rdname column
    +#' @rdname between
     #' @export
     setGeneric("between", function(x, bounds) { standardGeneric("between") })
     
    -#' @rdname column
    +#' @rdname cast
     #' @export
     setGeneric("cast", function(x, dataType) { standardGeneric("cast") })
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("contains", function(x, ...) { standardGeneric("contains") })
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("desc", function(x) { standardGeneric("desc") })
     
    -#' @rdname column
    +#' @rdname endsWith
     #' @export
     setGeneric("endsWith", function(x, suffix) { standardGeneric("endsWith") })
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("getField", function(x, ...) { standardGeneric("getField") })
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("getItem", function(x, ...) { standardGeneric("getItem") })
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("isNaN", function(x) { standardGeneric("isNaN") })
     
    -#' @rdname column
    +#' @rdname column functions
     #' @export
     setGeneric("isNull", function(x) { standardGeneric("isNull") })
     
    -#' @rdname column
    +#' @rdname column functions
    --- End diff --
    
    not sure i follow the intent here - do we want these all in the same rd ? 
Also is there supposed to be an underscore (i.e. `column_functions`) instead of 
a space ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to