Github user rxin commented on the issue:
https://github.com/apache/spark/pull/12268
@HyukjinKwon i just took another look at this. Can you separate this into
multiple, smaller pull requests?
IIUC, the main change you want to do is to get rid of the
StringIteratorReader. Why don't you just submit a patch for only that? It'd
make it much easier to review and merge. The problem with mixing multiple
things into a single pull request is that it significantly increases the
overhead to review, and makes it almost impossible to merge.
We can start with this one change, and then do other refactorings later.
Also it would be great to show some benchmark numbers since it is a
performance improvement. The other thing I'd like to see (in a separate pull
request) is to try use the Record API from univocity and compare the
performance with our current data cast API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
