Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13798#discussion_r67815785
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -606,10 +607,10 @@ setMethod("unpersist",
     #'
     #' The following options for repartition are possible:
     #' \itemize{
    -#'  \item{"Option 1"} {Return a new SparkDataFrame partitioned by
    +#'  \item{1.} {Return a new SparkDataFrame partitioned by
     #'                      the given columns into `numPartitions`.}
    -#'  \item{"Option 2"} {Return a new SparkDataFrame that has exactly 
`numPartitions`.}
    -#'  \item{"Option 3"} {Return a new SparkDataFrame partitioned by the 
given column(s),
    +#'  \item{2.} {Return a new SparkDataFrame that has exactly 
`numPartitions`.}
    +#'  \item{3.} {Return a new SparkDataFrame partitioned by the given 
column(s),
     #'                      using `spark.sql.shuffle.partitions` as number of 
partitions.}
    --- End diff --
    
    it mentioned "these options" (as in one of these choices) on the line 
before, so I thought it's nicer to numbered the options.
    in other cases we have unnumbered bullets if they are enum values and so on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to