Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13778#discussion_r67894797
--- Diff: python/pyspark/sql/tests.py ---
@@ -558,6 +558,18 @@ def check_datatype(datatype):
_verify_type(PythonOnlyPoint(1.0, 2.0), PythonOnlyUDT())
self.assertRaises(ValueError, lambda: _verify_type([1.0, 2.0],
PythonOnlyUDT()))
+ schema = StructType().add("key", LongType()).add("val",
PythonOnlyUDT())
+ df = self.spark.createDataFrame(
+ [(i % 3, PythonOnlyPoint(float(i), float(i))) for i in
range(10)],
+ schema=schema)
+ df.show()
+
+ schema = StructType().add("key", LongType()).add("val",
ArrayType(PythonOnlyUDT()))
--- End diff --
Same here, need its own named unit test (so that it's easier to identify
the problem if the test fails) - unit tests should test only one thing, the
thing tested here is `test_nested_udt_in_df` (perhaps also worthwhile to check
Map works?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
