Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1853#discussion_r16030631
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -30,6 +30,7 @@ private[spark] object SQLConf {
val SHUFFLE_PARTITIONS = "spark.sql.shuffle.partitions"
val CODEGEN_ENABLED = "spark.sql.codegen"
val DIALECT = "spark.sql.dialect"
+ val INCREMENTAL_COLLECT_ENABLED = "spark.sql.incrementalCollect"
--- End diff --
OK. I put it in `SQLConf` because of exactly the same reason [Zongheng
mentioned](https://github.com/apache/spark/pull/1819/files#r15913270), and also
had mixed feelings about this. I'd prefer to have something like Hive
`ConfVars` to define all configurations, but let's do it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
