Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13603#discussion_r67904173
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -576,6 +576,62 @@ private[spark] class TaskSetManager(
       }
     
       /**
    +   * Check whether the given task set has been blacklisted to the point 
that it can't run anywhere.
    +   *
    +   * It is possible that this taskset has become impossible to schedule 
*anywhere* due to the
    +   * blacklist.  The most common scenario would be if there are fewer 
executors than
    +   * spark.task.maxFailures. We need to detect this so we can fail the 
task set, otherwise the job
    +   * will hang.
    +   *
    --- End diff --
    
    After further thought I think this is actually O(maxTaskFailures + # tasks) 
right? Since you might need to first iterate through all of the tasks to find 
one that hasn't started yet, and then iterate through some failed executors?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to