GitHub user ericl opened a pull request:

    https://github.com/apache/spark/pull/13814

    [SPARK-16003] SerializationDebugger runs into infinite loop

    ## What changes were proposed in this pull request?
    
    This fixes SerializationDebugger to not recurse forever when `writeReplace` 
returns an object of the same class, which is the case for at least the 
`SQLMetrics` class.
    
    See also the OpenJDK unit tests on the behavior of recursive 
`writeReplace()`:
    
https://github.com/openjdk-mirror/jdk7u-jdk/blob/f4d80957e89a19a29bb9f9807d2a28351ed7f7df/test/java/io/Serializable/nestedReplace/NestedReplace.java
    
    cc @davies @cloud-fan 
    
    ## How was this patch tested?
    
    Unit tests for SerializationDebugger.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ericl/spark spark-16003

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13814
    
----
commit 3237c278003d4ab956cd3be6148793f4c405cc42
Author: Eric Liang <[email protected]>
Date:   2016-06-21T20:09:04Z

    Tue Jun 21 13:09:04 PDT 2016

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to