Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13758#discussion_r67992529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
---
@@ -23,7 +23,60 @@ import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.types.{DataType, Decimal}
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
-class GenericArrayData(val array: Array[Any]) extends ArrayData {
+object GenericArrayData {
+ def allocate(seq: Seq[Any]): GenericArrayData = new
GenericRefArrayData(seq)
--- End diff --
Please make all allocate methods return the type they are actually
allocating. That will increase the chance that we deal with a monomorphic
callsite in further code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
