Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13764#discussion_r67994276
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -462,4 +463,27 @@ class OrcQuerySuite extends QueryTest with
BeforeAndAfterAll with OrcTest {
}
}
}
+
+ test("column nullability and comment - write and then read") {
+ val schema = StructType(
+ StructField("cl1", IntegerType, nullable = false,
+ new MetadataBuilder().putString("comment", "test").build()) ::
--- End diff --
Yeah I am afraid it is. I just grepped through the code base and there are
a few places where we do this, for example:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala#L1434-L1438
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala#L397-L404
+1 for adding a convenience method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
