Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/13820#discussion_r67995869
--- Diff: R/pkg/R/mllib.R ---
@@ -124,24 +138,21 @@ setMethod("spark.glm", signature(data =
"SparkDataFrame", formula = "formula"),
#' summary(model)
#' }
#' @note glm since 1.5.0
+#' @seealso \link{spark.glm}
setMethod("glm", signature(formula = "formula", family = "ANY", data =
"SparkDataFrame"),
function(formula, family = gaussian, data, epsilon = 1e-6, maxit
= 25) {
spark.glm(data, formula, family, tol = epsilon, maxIter =
maxit)
})
-#' Get the summary of a generalized linear model
-#'
-#' Returns the summary of a model produced by glm() or spark.glm(),
similarly to R's summary().
+# Returns the summary of a model produced by glm() or spark.glm(),
similarly to R's summary().
--- End diff --
I get this is intentional, but I'd suggest adding extra empty newline
between `#` & `#'` line - it's very easy to newcomers to make mistakes
copy/paste doc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
