Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13758#discussion_r67995936
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
 ---
    @@ -142,3 +196,414 @@ class GenericArrayData(val array: Array[Any]) extends 
ArrayData {
         result
       }
     }
    +
    +final class GenericIntArrayData(val primitiveArray: Array[Int]) extends 
GenericArrayData {
    +  override def array(): Array[Any] = primitiveArray.toArray
    +
    +  override def copy(): ArrayData = new GenericIntArrayData(primitiveArray)
    --- End diff --
    
    Hmm, I should clone the backing array. I should return the actual type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to