Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1799#discussion_r16033699
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -246,8 +250,13 @@ object SparkEnv extends Logging {
"."
}
- val shuffleManager = instantiateClass[ShuffleManager](
- "spark.shuffle.manager",
"org.apache.spark.shuffle.hash.HashShuffleManager")
+ // Let the user specify short names for shuffle managers
+ val shortShuffleMgrNames = Map(
+ "hash" -> "org.apache.spark.shuffle.hash.HashShuffleManager",
+ "sort" -> "org.apache.spark.shuffle.sort.SortShuffleManager")
+ val shuffleMgrName = conf.get("spark.shuffle.manager", "hash")
--- End diff --
I'd rather not change the configuration under the user, that would be
confusing if they later print it or look in the web UI. Instead, maybe add a
SparkEnv.getShuffleManagerClass(conf: SparkConf) that can return the real class
name.
Also I'd be fine initializing the ShuffleBlockManager after the
ShuffleManager if that works, and using isInstanceOf. That would be the
cleanest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
