GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13845
[SPARK-13023][PROJECT INFRA][FOLLOWUP][BRANCH-1.6] Unable to check `root`
module ending up failure of Python tests
## What changes were proposed in this pull request?
This PR fixes incorrect checking for `root` module (meaning all tests).
I realised that https://github.com/apache/spark/pull/13806 is being failed
due to this one.
The PR corrects two files in `sql` and `core`. Since it seems fixing `core`
module triggers all tests by `root` value from `determine_modules_for_files`.
So, `changed_modules` becomes as below:
```
['root', 'sql']
```
and `dependent_modules` becaomes as below:
```
['pyspark-mllib', 'pyspark-ml', 'hive-thriftserver', 'sparkr', 'mllib',
'examples', 'pyspark-sql']
```
Now, `modules_to_test` does not include `root`, this checking is skipped
but then both `changed_modules` and `modules_to_test` are being merged after
that. So, this includes `root` module to test.
This ends up with failing with the message below (e.g.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60990/consoleFull):
```
Error: unrecognized module 'root'. Supported modules: pyspark-core,
pyspark-sql, pyspark-streaming, pyspark-ml, pyspark-mllib
```
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark fix-build-1.6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13845.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13845
----
commit 84ad6797d22966c04f07cb71afe8369dc25cafb3
Author: hyukjinkwon <[email protected]>
Date: 2016-06-22T13:13:09Z
Check modules to test correctly
commit 6e72652b9b32b40cccaa20eaf2f9936ec3105812
Author: hyukjinkwon <[email protected]>
Date: 2016-06-22T13:17:40Z
Fix comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
