Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13842#discussion_r68060626
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -41,13 +44,7 @@ private[spark] trait Logging {
}
// Method to get or create the logger for this object
- protected def log: Logger = {
- if (log_ == null) {
- initializeLogIfNecessary(false)
- log_ = LoggerFactory.getLogger(logName)
- }
- log_
- }
+ protected def log: Logger = log_
--- End diff --
Good point. I think that can be removed. I don't see the point of it, as
neither it nor its subclass even logs anything directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
