GitHub user tmagrino opened a pull request:

    https://github.com/apache/spark/pull/13858

    [SPARK-16148] [Scheduler] Allow for underscores in TaskLocation in the 
Executor ID

    ## What changes were proposed in this pull request?
    
    Previously, the TaskLocation implementation would not allow for executor 
ids which include underscores.  This tweaks the string split used to get the 
hostname and executor id, allowing for underscores in the executor id.
    
    This addresses the JIRA found here: 
https://issues.apache.org/jira/browse/SPARK-16148
    
    This is moved over from a previous PR against branch-1.6: 
https://github.com/apache/spark/pull/13857
    
    ## How was this patch tested?
    
    Ran existing unit tests for core and streaming.  Manually ran a simple 
streaming job with an executor whose id contained underscores and confirmed 
that the job ran successfully.
    
    This is my original work and I license the work to the project under the 
project's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tmagrino/spark fixtasklocation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13858
    
----
commit af1c902c8d976a59b354df034b3886389137c8b2
Author: Tom Magrino <[email protected]>
Date:   2016-06-22T18:08:23Z

    Fixed split command in TaskLocation to allow for _ in executor id.
    
    Also updated the comment to indicate the string format which includes
    the executor id.

commit b497dc908e8429547a448e81fc4fcb792ff14dda
Author: Tom Magrino <[email protected]>
Date:   2016-06-22T18:20:39Z

    Code style fix.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to