Github user tmagrino commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13861#discussion_r68157952
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala 
---
    @@ -149,6 +150,12 @@ private[ui] class ExecutorTable(stageId: Int, 
stageAttemptId: Int, parent: Stage
                     {Utils.bytesToString(v.diskBytesSpilled)}
                   </td>
                 }}
    +            <td>
    +              {val logs = 
parent.executorsListener.executorToLogUrls.getOrElse(k, Map.empty)
    +               logs.map {
    +                case (logName, logUrl) => <div><a 
href={logUrl}>{logName}</a></div>
    +              }}
    --- End diff --
    
    I'll admit, I'm still extremely new to Scala and so I haven't really picked 
up a good sense of formatting yet and tried to follow a convention similar to 
lines above this.  Would this 
https://gist.github.com/tmagrino/1dddaa4f2a9b0961d98809482d0cc4bb be considered 
better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to