Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13884#discussion_r68355286
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -688,6 +688,14 @@ object FoldablePropagation extends Rule[LogicalPlan] {
case c: Command =>
stop = true
c
+ // For outer join, although its output attributes are derived from
its children, they are
+ // actually different attributes: the output of outer join is not
always picked from its
+ // children, but can also be null.
+ // TODO(cloud-fan): It seems more reasonable to use new attributes
as the output attributes
+ // of outer join.
--- End diff --
Yea, I think we should consider it for 2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
