Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13852#discussion_r68433047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -174,8 +174,8 @@ sealed abstract class AggregateFunction extends
Expression with ImplicitCastInpu
def inputAggBufferAttributes: Seq[AttributeReference]
/**
- * Indicates if this function supports partial aggregation.
- * Currently Hive UDAF is the only one that doesn't support partial
aggregation.
+ * Indicates if this function needs to aggregate values group-by-group
in a single step.
+ * If false, we must always use a `SortAggregateExec` operator without
partial aggregates.
*/
def supportsPartial: Boolean = true
--- End diff --
I do like the names, they describe however the inverse of what this flag
does. We could invert the flag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
