Github user AlekseiS commented on a diff in the pull request:
https://github.com/apache/spark/pull/13893#discussion_r68438486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -64,10 +64,12 @@ object PhysicalOperation extends PredicateHelper {
val substitutedFields =
fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]]
(Some(substitutedFields), filters, other,
collectAliases(substitutedFields))
- case Filter(condition, child) if condition.deterministic =>
+ case Filter(condition, child) =>
+ val (deterministicFilters, nondeterministicFilters) =
splitConjunctivePredicates(condition)
+ .partition(_.deterministic)
val (fields, filters, other, aliases) =
collectProjectsAndFilters(child)
- val substitutedCondition = substitute(aliases)(condition)
- (fields, filters ++
splitConjunctivePredicates(substitutedCondition), other, aliases)
+ val substitutedFilters =
deterministicFilters.map(substitute(aliases)(_))
+ (fields, filters ++ deterministicFilters, other, aliases)
--- End diff --
Likely there's a bug. I think you want to use "substitutedFilters" instead
of "deterministicFilters" here. I think you can also add a test with
substitution for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
