Github user avulanov commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13868#discussion_r68476343
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -691,7 +692,8 @@ private[sql] class SQLConf extends Serializable with 
CatalystConf with Logging {
       def variableSubstituteDepth: Int = getConf(VARIABLE_SUBSTITUTE_DEPTH)
     
       def warehousePath: String = {
    -    getConf(WAREHOUSE_PATH).replace("${system:user.dir}", 
System.getProperty("user.dir"))
    +    new File(getConf(WAREHOUSE_PATH).replace("${system:user.dir}",
    +      System.getProperty("user.dir"))).toURI.toString
    --- End diff --
    
    You are correct, `toURI` behaves strange when the path is not local:
    ```
    scala> new File("hdfs://m.com:9000/data").toURI
    res6: java.net.URI = 
file:/C:/Program%20Files%20(x86)/scala/bin/hdfs:/m.com:9000
    /data
    ```
    I think we can add a check and apply `toURI` when the string does not start 
from `hdfs:` or `s3`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to