Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1760#discussion_r16066399
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala 
---
    @@ -70,6 +72,17 @@ class TestHiveContext(sc: SparkContext) extends 
HiveContext(sc) {
         set("hive.metastore.warehouse.dir", warehousePath)
       }
     
    +  val testTmpDir = if (System.getProperty("user.dir").endsWith("sql" +
    --- End diff --
    
    Could this just be:
    ```scala
    val testTempDir = File.createtempfile("", "spark.hive.tmp")
    testTempDir.delete()
    testTempDir.mkdir()
    ```
    
    I'm not sure why we would want to keep temporary files in the source tree 
instead of the system temporary folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to