Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13847#discussion_r68487696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MapData.scala ---
@@ -19,6 +19,10 @@ package org.apache.spark.sql.catalyst.util
import org.apache.spark.sql.types.DataType
+/**
+ * `MapData` should not implement `equals` and `hashCode` because the type
cannot be used as join
--- End diff --
it's not your fault, but I think we need to add some comment for `MapData`
itself, and then follows this comment as a note. We can simply say: `An
internal data representation for map type in Spark SQL`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
