Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13760#discussion_r68508656
--- Diff: R/pkg/R/group.R ---
@@ -243,17 +236,73 @@ setMethod("gapply",
signature(x = "GroupedData"),
function(x, func, schema) {
try(if (is.null(schema)) stop("schema cannot be NULL"))
--- End diff --
I think we use `stop` or `warn` directly in SparkR without wrapping in a
`try` block. I think the `try` block is useful if we want to catch an error of
one kind and then reformat it or show a different error etc. In this case
`stop` should be sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
