Github user tdas commented on the issue:
https://github.com/apache/spark/pull/11863
I took a quick glance, and I think the following.
1. I like the LocationStrategy. But needs Java tests for each of the
strategies.
2. Regarding ConsumerStrategy, I think I am trying to understand it a
little more. And I am a little confused on what happens in the Subscribe
strategy when the subscribed partitions change. I have left inline comments in
the code.
3. Would nice to have LocationStrategy after ConsumerStrtategy in the
parameter list, as the latter is more important than the former (location
strategy can have preferConsistent as default).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
