Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13915#discussion_r68534694
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala ---
@@ -200,7 +200,7 @@ private[ml] object WeightedLeastSquares {
* Adds an instance.
*/
def add(instance: Instance): this.type = {
- val Instance(l, w, f) = instance
+ val Instance(label, w, f) = instance
--- End diff --
Feel free to just write out weight and feature too, while we're touching
this, for consistency
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
