Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/13848#discussion_r68635687
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -819,6 +833,8 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
assert(sched.endedTasks(id) === Success)
}
+ // check speculatable tasks requires a non-zero runtime for the tasks
--- End diff --
How about:
checkSpeculatableTasks checks that the task runtime is greater than the
threshold for speculating. Since we use a threshold of 0 for speculation,
tasks need to be running for > 0ms, so advance the clock by 1ms here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
