Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/13826#discussion_r68635883
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -293,13 +292,16 @@ private[spark] class TaskSchedulerImpl(
// Also track if new executor is added
var newExecAvail = false
for (o <- offers) {
- executorIdToHost(o.executorId) = o.host
- executorIdToTaskCount.getOrElseUpdate(o.executorId, 0)
if (!executorsByHost.contains(o.host)) {
executorsByHost(o.host) = new HashSet[String]()
+ }
+ if (!executorIdToHost.contains(o.executorId)) {
--- End diff --
At first I was keeping them separate, but I discovered that
https://github.com/apache/spark/pull/13603 was flaky without the changes
proposed here. So now that PR just has all of this one merged into it. My
intention is that we merge this one first, including the commit which does the
test cleanup. (I don't think it particularly matters which PR the test cleanup
goes in, but might as well put it in the first one.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
