Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13891#discussion_r68711572
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -635,6 +636,15 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
}
}
+ private def copyToTri(): Unit = {
+ var ii = 0
+ for(i <- 0 until k)
--- End diff --
I think this might fail the style check for missing space before the paren.
Also, I think the received wisdom is that for loops are slow in Scala? if
this is performance-critical, you may convert to while loops. Also you can
cache i*k from the outer loop below in the inner loop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
