Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r68746318
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -110,16 +113,17 @@ public void pointTo(Object baseObject, long
baseOffset, int sizeInBytes) {
this.baseObject = baseObject;
this.baseOffset = baseOffset;
this.sizeInBytes = sizeInBytes;
+ this.headerInBytes = calculateHeaderPortionInBytes(numElements);
}
@Override
public boolean isNullAt(int ordinal) {
assertIndexIsValid(ordinal);
- return getElementOffset(ordinal) < 0;
+ return BitSetMethods.isSet(baseObject, baseOffset + 4, ordinal);
}
@Override
- public Object get(int ordinal, DataType dataType) {
+ public final Object get(int ordinal, DataType dataType) {
--- End diff --
it's already a final class, no need to add final to methods
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
