Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13765#discussion_r68788331
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -537,12 +537,19 @@ object CollapseProject extends Rule[LogicalPlan] {
}
/**
- * Combines adjacent [[Repartition]] operators by keeping only the last
one.
+ * Combines adjacent [[Repartition]] and [[RepartitionByExpression]]
operator combinations
+ * by keeping only the one.
*/
object CollapseRepartition extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
case Repartition(numPartitions, shuffle, Repartition(_, _, child)) =>
Repartition(numPartitions, shuffle, child)
+ case Repartition(numPartitions, _, r: RepartitionByExpression) =>
+ r.copy(numPartitions = Some(numPartitions))
+ case RepartitionByExpression(exprs, Repartition(_, _, child),
numPartitions) =>
+ RepartitionByExpression(exprs, child, numPartitions)
+ case RepartitionByExpression(exprs, RepartitionByExpression(_, child,
_), numPartitions) =>
+ RepartitionByExpression(exprs, child, numPartitions)
--- End diff --
Yep. @yhuai .
I think this needs to work in the exactly same way with
```
SELECT a
FROM (SELECT b
FROM t
GROUP BY b)
GROUPY BY a
```
If there is something I missed, please let me know. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
