Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13603#discussion_r68808784
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/BlacklistIntegrationSuite.scala 
---
    @@ -91,6 +91,31 @@ class BlacklistIntegrationSuite extends 
SchedulerIntegrationSuite[MultiExecutorM
         assertDataStructuresEmpty(noFailure = true)
       }
     
    +  // Make sure that if we've failed on all executors, but haven't hit 
task.maxFailures yet, the job
    +  // doesn't hang
    +  testScheduler(
    +    "SPARK-15865 Progress with fewer executors than maxTaskFailures",
    +    extraConfs = Seq(
    +      // set this to something much longer than the test duration
    +      "spark.scheduler.executorTaskBlacklistTime" -> "10000000",
    +      "spark.testing.nHosts" -> "2",
    +      "spark.testing.nExecutorsPerHost" -> "1",
    +      "spark.testing.nCoresPerExecutor" -> "1"
    +    )
    +  ) {
    --- End diff --
    
    super nit but can you put these on the previous line? Was confused by the 
syntax here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to