Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1632#discussion_r16091329
  
    --- Diff: 
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
    @@ -134,6 +136,7 @@ private[spark] class ConnectionManager(
       // to be able to track asynchronous messages
       private val idCount: AtomicInteger = new AtomicInteger(1)
     
    +  private var isAckTimeout = false
    --- End diff --
    
    Logically, this seems like per-message state, so it feels wrong to have it 
as a ConnectionManager-wide variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to