Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13517#discussion_r68869270
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -45,11 +45,11 @@ statement
| ALTER DATABASE identifier SET DBPROPERTIES tablePropertyList
#setDatabaseProperties
| DROP DATABASE (IF EXISTS)? identifier (RESTRICT | CASCADE)?
#dropDatabase
| createTableHeader ('(' colTypeList ')')? tableProvider
- (OPTIONS tablePropertyList)?
+ (OPTIONS optionParameterList)?
(PARTITIONED BY partitionColumnNames=identifierList)?
bucketSpec?
#createTableUsing
| createTableHeader tableProvider
- (OPTIONS tablePropertyList)?
--- End diff --
I hope I understood this correctly. I guess you meant the `tableProperty`
rule, for example, as below:
```antlr
tableProperty
: key=tablePropertyKey (EQ? value= optionValue)?
;
```
If so, I am worried if this affects other rules such as `DBPROPERTIES` and
`TBLPROPERTIES` (allowing other types as values). I made this separate because
it seems allowing other types in `OPTIONS` clause complies standard SQL.
If not, could you give me an advice in a bit more detail please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
