Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1765#discussion_r16094402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
@@ -170,6 +164,9 @@ case class HashOuterJoin(
def output = left.output ++ right.output
+ @transient private[this] lazy val DUMMY_LIST = Seq[Row](null)
+ @transient private[this] lazy val EMPTY_LIST = Seq.empty[Row]
--- End diff --
This is a fairly minor nit but defining `EMPTY_LIST` instead of just using
`Seq.empty[Row]`
- Takes up extra space in the class
- Requires double checked locking / lazy initialization logic for each
access
- Requires the developer to find the variable and figure out what it
means, instead of `Seq.empty[Row]` which is standard scala.
All to save 4 characters?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
