Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1632#discussion_r16094928
--- Diff:
core/src/main/scala/org/apache/spark/network/ConnectionManager.scala ---
@@ -836,9 +845,14 @@ private[spark] class ConnectionManager(
def sendMessageReliably(connectionManagerId: ConnectionManagerId,
message: Message)
: Future[Message] = {
val promise = Promise[Message]()
+
+ val ackTimeoutMonitor = new Timer(s"Ack Timeout Monitor-" +
+ "${connectionManagerId}-MessageId(${message.id})", true)
+
val status = new MessageStatus(message, connectionManagerId, s => {
+ ackTimeoutMonitor.cancel()
--- End diff --
On closer inspection, I guess the race only sets `isAckTimeout` because the
`foreach` in `messageStatuses.remove(message.id).foreach` will guard against
the race, so we won't end up failing the promise after calling success on it
from the other thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
