Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13989#discussion_r69073191
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -139,18 +139,6 @@ private[hive] class HiveMetastoreCatalog(sparkSession:
SparkSession) extends Log
}
def refreshTable(tableIdent: TableIdentifier): Unit = {
- // refreshTable does not eagerly reload the cache. It just invalidate
the cache.
- // Next time when we use the table, it will be populated in the cache.
- // Since we also cache ParquetRelations converted from Hive Parquet
tables and
- // adding converted ParquetRelations into the cache is not defined in
the load function
- // of the cache (instead, we add the cache entry in
convertToParquetRelation),
- // it is better at here to invalidate the cache to avoid confusing
waring logs from the
- // cache loader (e.g. cannot find data source provider, which is only
defined for
- // data source table.).
--- End diff --
Keep the comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
