Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/13989#discussion_r69075247
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
---
@@ -85,5 +85,10 @@ case class LogicalRelation(
expectedOutputAttributes,
metastoreTableIdentifier).asInstanceOf[this.type]
+ override def refresh(): Unit = relation match {
+ case fs: HadoopFsRelation => fs.refresh()
--- End diff --
I don't agree on this one. LogicalRelation might not be the only one that
needs to override this in the future. There can certainly be other logical
plans in the future that keep some state and needs to implement refresh. The
definition of "refresh" itself with a default implementation also means only
plans that need to refresh anything should override it.
I'm going to update refresh in LogicalPlan to make this more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
