Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/13996
1. "When abstract class, you can later add defined methods which the users
can override if needed, but does not break compatibility of existing
implementations." This is what I'm taking issue with. It's confusing binary
compatibility with actual api compatibility. Changing the class and silently
slipping in a new default method into someone's code may preserve binary
compatibility, at the cost of actually breaking their code at runtime and
losing them their job.
Clearly not a big change from a lines of code perspective to move trait to
abstract class, so I can do it quickly, but I'd like to at least hear your
response to that concern.
Other changes, no concerns, I can add them to my pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
