Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13998#discussion_r69216207
--- Diff:
external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java
---
@@ -44,37 +44,39 @@ public void testConsumerStrategyConstructors() {
kafkaParams.put("bootstrap.servers", "not used");
final scala.collection.Map<String, Object> sKafkaParams =
JavaConverters.mapAsScalaMapConverter(kafkaParams).asScala();
- final Map<TopicPartition, Object> offsets = new HashMap<>();
+ final Map<TopicPartition, Long> offsets = new HashMap<>();
offsets.put(tp1, 23L);
final scala.collection.Map<TopicPartition, Object> sOffsets =
--- End diff --
yeah. I guess it better to test these explicitly nonetheless, rather than
writing tests that assume certain JVM behavior. No strong feelings for this
though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
