Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13974#discussion_r69231758
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala
 ---
    @@ -19,6 +19,11 @@ package org.apache.spark.sql.catalyst.util
     
     class ArrayBasedMapData(val keyArray: ArrayData, val valueArray: 
ArrayData) extends MapData {
       require(keyArray.numElements() == valueArray.numElements())
    +  for (i <- 0 until keyArray.numElements()) {
    --- End diff --
    
    Let's use a `while`-loop to replace `for` since Scala `for` is super slow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to