Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14009#discussion_r69259865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -462,17 +462,15 @@ class SessionCatalog(
}
}
- // TODO: It's strange that we have both refresh and invalidate here.
-
/**
* Refresh the cache entry for a metastore table, if any.
*/
- def refreshTable(name: TableIdentifier): Unit = { /* no-op */ }
-
- /**
- * Invalidate the cache entry for a metastore table, if any.
- */
- def invalidateTable(name: TableIdentifier): Unit = { /* no-op */ }
+ def refreshTable(name: TableIdentifier): Unit = {
+ // Go through temporary tables and invalidate them.
--- End diff --
In the test case of `HiveMetadataCacheSuite.scala`, users might refresh the
base table by using `spark.catalog.refreshTable("view_refresh")`. Normally,
they do not specify the current database name. Then, its database name is
empty. Thus, this table will be treated as a temporary table. This comment
might need a correction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
