Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1899#issuecomment-51953660
After a closer look, it looks like the existing `spark-ec2` already names
instances after `cluster_name`, so it's safe and backwards-compatible to use
that to identify existing clusters.
The code in this PR looks good; a couple of TODOs:
- Update the pull request title to reference a new or existing JIRA. I
think [SPARK-2333](https://issues.apache.org/jira/browse/SPARK-2333) fits the
bill, so I'd name it something like "[SPARK-2333] Allow multiple spark-ec2
clusters to be launched in the same security group".
- Maybe update the intro of the [Running Spark on EC2
guide](http://spark.apache.org/docs/latest/ec2-scripts.html) guide to explain
that the clusters are identified by their instances' names instead of security
groups.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
