Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13389#discussion_r69280087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/CatalystWriteSupport.scala
---
@@ -150,7 +150,8 @@ private[parquet] class CatalystWriteSupport extends
WriteSupport[InternalRow] wi
case StringType =>
(row: SpecializedGetters, ordinal: Int) =>
-
recordConsumer.addBinary(Binary.fromByteArray(row.getUTF8String(ordinal).getBytes))
+ recordConsumer.addBinary(
+
Binary.fromReusedByteArray(row.getUTF8String(ordinal).getBytes))
--- End diff --
Thank you for your review! (Actually it is `UTF8String`. So, it has to be
converted into `String` to use `Binary.fromString`).. though.. I am a bit
worried that it might possibly be reused in the future (although I think it is
not reused for now).
This can write corrupt statistics if this is reused.. Is my understanding
correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
