Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13957#discussion_r69363665
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -136,7 +149,8 @@ class TextSocketSourceProvider extends
StreamSourceProvider with DataSourceRegis
parameters: Map[String, String]): Source = {
val host = parameters("host")
val port = parameters("port").toInt
- new TextSocketSource(host, port, sqlContext)
+ new TextSocketSource(host, port,
+ parameters.getOrElse("includeTimestamp", "false").toBoolean,
sqlContext)
--- End diff --
but its better to have single function that catches that error and prints a
better error message like "value of option includeTimestamp cannot be parsed.
allowed values are "true" or "false".
also it needs to be a IllegalArgumentException
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
