Github user markhamstra commented on the pull request:

    https://github.com/apache/spark/pull/1909#issuecomment-51965072
  
    Erik, you've been doing some great work on making non-lazy transforms lazy! 
 I haven't had time to thoroughly review your recent PRs, but can you do some 
checks and probably add some tests to make sure that all of your recent efforts 
also work correctly not only for synchronous actions on RDDs (collect, count, 
et al), but also the async actions in AsyncRDDActions.scala?  It looked to me 
like at least the RangePartitioner work, while better than what is in Spark 
now, still had some troubles in async actions (essentially, the production of 
the rangeBounds doesn't get captured within the FutureAction, so it isn't 
cancellable, etc.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to