GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/14035
[SPARK-16356][ML] Add testImplicits for ML unit tests and promote toDF()
## What changes were proposed in this pull request?
This was suggested in
https://github.com/apache/spark/commit/101663f1ae222a919fc40510aa4f2bad22d1be6f#commitcomment-17114968.
This PR adds `testImplicits` to `MLlibTestSparkContext` so that some
implicits such as `toDF()` can be sued across ml tests.
This PR also changes all the usages of `spark.createDataFrame( ... )` to
`toDF()` where applicable in ml tests in Scala.
## How was this patch tested?
Existing tests should work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark minor-ml-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14035.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14035
----
commit 79453ac4806bc55dc5ac57da1fb4c706cdd0a762
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-28T04:25:35Z
Promote toDF() instead of createDataFrame from a Product-type RDD
commit 902b9132a029df3f879d70e0f01c04b640a97ebc
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-28T04:35:49Z
Fix indentation
commit 0df2e44c1871ce30a29878450b0d2024779a3e73
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-06-29T03:31:15Z
Add some more tests to use toDF API
commit 4f1fc1cfdd9d3cd55ce56b852d5a4a6d6b7ea958
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-07-03T04:46:03Z
Fetch upstream
commit 5f7f85b40709eee0eb261edd24eaaef9b7fc3783
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-07-03T05:45:43Z
Fix some more cases
commit 52e7f1601df73dc35aac7627a6e0466b19cd8248
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-07-03T05:56:24Z
Take out the change in SQL and consistent imports
commit 54c27d4d359a7e6ad445856e06f15e29132d582c
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-07-03T06:12:35Z
Remove unused imports and cleanup nits
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
