Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14038#discussion_r69519846
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
---
@@ -230,6 +236,15 @@ trait FileFormat {
}
/**
+ * Return a `SerializablePathFilter` class to filter qualified files for
this format.
+ */
+ def getPathFilter(): SerializablePathFilter = {
--- End diff --
What is the semantics of the return value of the method? Seems that it
should never return a null filter since it defaults to an "accept all" filter.
If this is true, it's unnecessary to use `Option` to wrap returned filters
elsewhere in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
