Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13708#discussion_r69604865
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
@@ -229,20 +229,20 @@ private[ui] class JobPage(parent: JobsTab) extends
WebUIPage("job") {
}
}
+ val basePath = "jobs/job"
+
val activeStagesTable =
- new StageTableBase(activeStages.sortBy(_.submissionTime).reverse,
- parent.basePath, parent.jobProgresslistener, isFairScheduler =
parent.isFairScheduler,
- killEnabled = parent.killEnabled)
+ new StageTableBase(request, activeStages, "activeStage",
parent.basePath,
+ basePath, parent.jobProgresslistener, parent.isFairScheduler,
parent.killEnabled, false)
val pendingOrSkippedStagesTable =
- new
StageTableBase(pendingOrSkippedStages.sortBy(_.stageId).reverse,
- parent.basePath, parent.jobProgresslistener, isFairScheduler =
parent.isFairScheduler,
- killEnabled = false)
+ new StageTableBase(request, pendingOrSkippedStages,
"pendingStage", parent.basePath,
+ basePath, parent.jobProgresslistener, parent.isFairScheduler,
false, false)
val completedStagesTable =
- new
StageTableBase(completedStages.sortBy(_.submissionTime).reverse,
parent.basePath,
- parent.jobProgresslistener, isFairScheduler =
parent.isFairScheduler, killEnabled = false)
+ new StageTableBase(request, completedStages, "completedStage",
parent.basePath,
+ basePath, parent.jobProgresslistener, parent.isFairScheduler,
false, false)
val failedStagesTable =
- new
FailedStageTable(failedStages.sortBy(_.submissionTime).reverse, parent.basePath,
- parent.jobProgresslistener, isFairScheduler =
parent.isFairScheduler)
+ new StageTableBase(request, failedStages, "failedStage",
parent.basePath,
+ basePath, parent.jobProgresslistener, parent.isFairScheduler,
false, true)
--- End diff --
nit: add the parameter names for `false` and `true`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
