Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14048#discussion_r69608096
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -184,7 +183,9 @@ class Dataset[T] private[sql](
// to happen right away to let these side effects take place eagerly.
case p if hasSideEffects(p) =>
LogicalRDD(queryExecution.analyzed.output,
queryExecution.toRdd)(sparkSession)
- case Union(children) if children.forall(hasSideEffects) =>
+ case Union(children) if children.exists(hasSideEffects) =>
--- End diff --
We catch `Union` here is not for queries like `INSERT ... UNION INSERT
...`, but for the multi insert syntax, see
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML#LanguageManualDML-InsertingdataintoHiveTablesfromqueries
So we don't need to handle `UNION ALL` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
