Github user yinxusen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14051#discussion_r69612547
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala 
---
    @@ -537,7 +537,7 @@ class RowMatrix @Since("1.0.0") (
       def tallSkinnyQR(computeQ: Boolean = false): QRDecomposition[RowMatrix, 
Matrix] = {
         val col = numCols().toInt
         // split rows horizontally into smaller matrices, and compute QR for 
each of them
    -    val blockQRs = rows.glom().map { partRows =>
    +    val blockQRs = rows.retag(classOf[Vector]).glom().map { partRows =>
    --- End diff --
    
    Since it's a known Java type erased issue 
(https://issues.apache.org/jira/browse/SPARK-2737), I am not sure wether to fix 
it or not. If leaving it as is, then Java users should aware of it and retag 
the JavaRDD themselves. Otherwise we fix its constructors with either retaging 
the `rows` or adding a new JavaRDD constructor. However this may not be a 
single sample. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to